Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.13 and drop EOL 3.7-3.8 #65

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for Python 3.13 and drop EOL 3.7-3.8 #65

wants to merge 7 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 16, 2024

@hugovk
Copy link
Contributor Author

hugovk commented Nov 16, 2024

The make build failures are from twine check:

build: commands[1]> twine check 'dist/*.whl' 'dist/*.tar.gz'
Checking dist/pytablewriter-1.2.0-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 156: Warning: Cannot scale image!                                 
           Could not get size from                                              
         "https://cdn.jsdelivr.net/gh/thombashi/pytablewriter@master/docs/pages/
         examples/table_format/text/ss/markdown.png":                           
           Requires Python Imaging Library.                                     
           Reading external files disabled.                                     
Checking dist/pytablewriter-1.2.0.tar.gz: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 156: Warning: Cannot scale image!                                 
           Could not get size from                                              
         "https://cdn.jsdelivr.net/gh/thombashi/pytablewriter@master/docs/pages/
         examples/table_format/text/ss/markdown.png":                           
           Requires Python Imaging Library.                                     
           Reading external files disabled.

This is caused by pypa/readme_renderer#304.

Two suggestions:

  • remove the :scale: parts from README.rst
  • programmatically remove them when reading the file in setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugovk